Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SCVal builders / helpers #60

Closed
tsachiherman opened this issue Mar 6, 2023 · 0 comments · Fixed by #61
Closed

update SCVal builders / helpers #60

tsachiherman opened this issue Mar 6, 2023 · 0 comments · Fixed by #61
Assignees
@paulbellamy
Labels
soroban-scrum

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented Mar 6, 2023 •
edited by tamirms
Loading

What ?

update SCVal builders / helpers to support the value overhaul.

Most of the work is already done in the js-stellar-base repo. The only tasks to complete this issue is updating the test cases in:

test/unit/server/get_contract_data_test.js

test/unit/server/simulate_transaction_test.js

Epic

stellar/stellar-cli#471
@tsachiherman tsachiherman mentioned this issue Mar 6, 2023
Closed
@Shaptic Shaptic mentioned this issue Mar 10, 2023
Closed
2 tasks
@paulbellamy paulbellamy assigned paulbellamy and unassigned tamirms Mar 14, 2023
@paulbellamy paulbellamy moved this from Backlog to In Progress in Platform Scrum Mar 14, 2023
@paulbellamy paulbellamy mentioned this issue Mar 14, 2023
Merged
@paulbellamy paulbellamy moved this from In Progress to Needs Review in Platform Scrum Mar 14, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulbellamy paulbellamy

Labels
soroban-scrum
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Soroban value overhaul stellar/js-soroban-client
3 participants
@paulbellamy @tamirms @tsachiherman