Remove deprecated classes and methods. #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overcat
commented
Jan 12, 2024
overcat
force-pushed
the
deprecated
branch
2 times, most recently
from
819a931
to
c683ae0
Compare
sreuland
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
lgtm, I left one comment for consideration on time bounds - https://github.com/stellar/java-stellar-sdk/pull/565/files#r1450823070
also, do you think it's worth capturing Breaking change liner notes to CHANELOG on this pr, itemizes each removed method and the recommended method to use in place? since the deprecation comment is gone?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following classes and methods have been marked as deprecated in previous releases, and now they have been removed
AccountResponse.Signer#getAccountId()has been removed, useAccountResponse.Signer#getKey()instead.OffersRequestBuilder#forAccount(String)has been removed, useOffersRequestBuilder#forSeller(String)instead.RootResponse#getProtocolVersion()has been removed, useRootResponse#getCurrentProtocolVersion()instead.SetOptionsOperationResponse#getSigner()has been removed, useSetOptionsOperationResponse#getSignerKey()instead.Transaction.Builderhas been removed, useTransactionBuilderinstead.TransactionBuilder#buildTimeBounds(long, long)has been removed, useTimeBounds#TimeBounds(long, long)instead.TransactionBuilder#addTimeBounds(TimeBounds)has been removed, useTransactionBuilder#addPreconditions(TransactionPreconditions)instead.