-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make StrKey
public.
#548
make StrKey
public.
#548
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We only need to focus on StrKey.java
and StrKeyTest.java
, we don't need to worry about other files.
@@ -428,4 +493,33 @@ private static boolean isInAlphabet(final byte[] arrayOctet) { | |||
} | |||
return true; | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor, can you pull this out to it's own file VersionByte.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think placing it here would also be a good choice, as there are no other parts relying on StrKey. Moreover, it is not public, so in the future, if necessary, we can still modify it without introducing breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Closes #318
In Soroban, we have many scenarios that require converting strkey into raw data. Making strkey public helps users handle it conveniently.
We will prudently make the following methods public:
In addition, we have modified the names of some functions to be consistent with other SDKs. Since StrKey was not previously public, there will be no destructive updates.