make StrKey public.
#548
Merged
make StrKey public.
#548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overcat
commented
Oct 6, 2023
There was a problem hiding this comment.
We only need to focus on StrKey.java and StrKeyTest.java, we don't need to worry about other files.
sreuland
reviewed
Oct 6, 2023
| @@ -428,4 +493,33 @@ private static boolean isInAlphabet(final byte[] arrayOctet) { | |||
| } | |||
| return true; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
minor, can you pull this out to it's own file VersionByte.java
There was a problem hiding this comment.
I think placing it here would also be a good choice, as there are no other parts relying on StrKey. Moreover, it is not public, so in the future, if necessary, we can still modify it without introducing breaking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #318
In Soroban, we have many scenarios that require converting strkey into raw data. Making strkey public helps users handle it conveniently.
We will prudently make the following methods public:
In addition, we have modified the names of some functions to be consistent with other SDKs. Since StrKey was not previously public, there will be no destructive updates.