Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some APIs to make it more convenient for users to construct InvokeHostFunction. #497

Merged
merged 7 commits into from
Jul 31, 2023
Merged

Add some APIs to make it more convenient for users to construct InvokeHostFunction. #497

merged 7 commits into from
Jul 31, 2023

Conversation

overcat
Copy link
Member

@overcat overcat commented Jul 31, 2023

Closes #488

@overcat
Copy link
Member Author

overcat commented Jul 31, 2023 •
edited
Loading

Hi @sreuland, does this design looks okay? If yes, I will add test cases.

@overcat overcat marked this pull request as ready for review July 31, 2023 12:48
overcat added 2 commits July 31, 2023 20:50
@overcat
add tests
015ba73
@overcat
add xdr test
193c144 
Cross-validation was performed with the Python SDK.
@overcat
Copy link
Member Author

overcat commented Jul 31, 2023

The PR is ready.

@overcat overcat requested a review from tamirms July 31, 2023 13:15
@tamirms tamirms merged commit 717426e into lightsail-network:soroban Jul 31, 2023
@overcat overcat deleted the invoke-alias branch July 31, 2023 13:56
@overcat overcat mentioned this pull request Aug 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamirms tamirms tamirms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@overcat @tamirms