fix okhttp3 class loader issue on android platform #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to replicate this problem in Android studio using emulator set at SDK version 28( android 'pie'):
The underlying issue was due to the shadowed jar, which rewrote an unintended 'com.android.org.conscrypt' hardcoded reference in the okhttp3 platform initialization which uses that as default to initialize networking from android:
https://github.com/square/okhttp/blob/parent-4.10.0/okhttp/src/main/kotlin/okhttp3/internal/platform/android/StandardAndroidSocketAdapter.kt#L61
it had a cycle when in error, trying to reference the platform instance while it was inside the platform init routine.
to avoid the problem, I tweaked the shadow config to ignore
com.android.org.conscrypt
,which stops it from trying to rewrite any refs to that in the .class files in the shadowed jar.after this change, I was able to verify the fix by running the same prior failing example with
org.stellar.sdk.Server("https://horizon.stellar.com/")
andOkHttpClient()
which now worked.Closes #450