Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the deployment CI that uploads the jar to the GitHub release [2] #453

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

marcelosalloum
Copy link
Contributor

@marcelosalloum marcelosalloum commented Aug 9, 2022

What

Fix the deployment CI that uploads the jar to the GitHub release by updating the software being used from https://github.com/tcnksm/ghr to https://github.com/github-release/github-release.

Why

Close #449.

In an attempt to fix the deploy job, that's failing at:
https://github.com/stellar/java-stellar-sdk/blob/417a84bd760321dba1ded0db0b9a32455737424f/.circleci/config.yml#L20-L29

With the error message:

Failed to upload one of assets: one of the goroutines failed: failed to upload asset: /root/project/build/libs/stellar-sdk.jar: failed to upload release asset: /root/project/build/libs/stellar-sdk.jar: Post https://uploads.github.com/repos/stellar/java-stellar-sdk/releases/73913299/assets?name=stellar-sdk.jar: http2: Transport: cannot retry err [stream error: stream ID 5; REFUSED_STREAM] after Request.Body was written; define Request.GetBody to avoid this error

Example of a failed deploy: deploy (678)

There was already an attempt to solve this in #452 without success.

@marcelosalloum marcelosalloum self-assigned this Aug 9, 2022
@marcelosalloum marcelosalloum marked this pull request as ready for review August 9, 2022 23:58
@marcelosalloum marcelosalloum requested a review from sreuland August 9, 2022 23:58
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, nice find on the alternative tool, and how to run it in CI.

@marcelosalloum marcelosalloum merged commit 3255ceb into master Aug 11, 2022
@overcat overcat deleted the fix-release-jar-update branch September 19, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Release tagging not publishing artifacts to GH release page
2 participants