#307: change offer ids to be represented in requests and response as long data type #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and response models as long data type
paulbellamy
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Looks good to me. Discussed in person whether we want to go with a Long, or a String. In the go sdk we use String, but let's look for other precedent in here and other sdks to match.
Edit: And for the breaking change, let's do a minor release. It is type-change only so should fail to compile if the user updates.
…lder if set to null
tamirms
approved these changes
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: some offer id values were modeled as string and others as integral longs in request and paired response objects.
Fix: make the offer id consistently modeled as integral long type in request and response objects.
Note: to achieve the consistency, this introduces breaking changes on existing public classes - changed some existing method signatures for offer ids on request and response models to use long data type instead of string, details in CHANGELOG. Looking for feedback on the approach, if it's worth it or not.
Closes #307