#375: Fix missing Liquidity Pool ID in AccountResponse Balance #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamirms
reviewed
Nov 15, 2021
CHANGELOG.md
Outdated
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| As this project is pre 1.0, breaking changes may happen for minor version bumps. A breaking change will get clearly notified in this log. | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| * Fixed bug, absence of Liquidity Pool ID in AccountResponse Balance ([#379](https://github.com/stellar/java-stellar-sdk/pull/379)). | |||
There was a problem hiding this comment.
nit: I would phrase it as "Fixed missing Liquidity Pool ID in AccountResponse Balance"
tamirms
approved these changes
Nov 15, 2021
tamirms
approved these changes
Nov 15, 2021
sreuland
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: After account retrieval from server for an account which had liquidity pool balances, the result instance of AccountResponse has a Balance instance for liquidity pool shares, however it was not populating the Balance:liquidityPoolId attribute, attempt to get the PoolId via Balance.getLiquidityPoolId() incorrectly returned an absence(empty Java Optional instance).
Fix: changed serialization to correctly map the server json response attribute for the optional LiquidityPoolId if present, into the Balance:liquidityPoolId object instance.
Closes #375