Correct the type of offerId
#303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why the CI running result is not displayed, but all tests have passed locally, I believe this is an internal error of CircleCI. |
leighmcculloch
approved these changes
Oct 22, 2020
There was a problem hiding this comment.
This looks like the correct fix to me. IDs in other response types use Long rather than Integer and I'm guessing we just missed this case whenever the IDs were expanded to be 64 bit.
I'm not an expert on this change though and so I don't think this should be merged until someone from the @stellar/horizon-committers can confirm that we're not missing something here.
Co-authored-by: Leigh McCulloch <[email protected]>
bartekn
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #302