Merge java-stellar-base into java-stellar-sdk #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to merge java-stellar-base and java-stellar-sdk into one repository and deprecate the former. The way Java works makes it difficult to export other package classes from the “parent” package, like we do in JS to separate low-level objects from classes responsible for network connections.
What is going to change
GsonSingleton
which aren't part of public API) are moved toorg.stellar.sdk.responses
package.org.stellar.base.xdr
classes are moved toorg.stellar.sdk.xdr
package.org.stellar.base
classes are now inorg.stellar.sdk
package.TransactionBuilderAccount
interface stays so it's easy to build a transaction using a rawKeyPair
and sequence number inorg.stellar.sdk.Account
object but it's also possible to use response from Horizon represented byorg.stellar.sdk.responses.AccountResponse
object.KeyPair.fromAddress
(useKeyPair.fromAccountId
)KeyPair.getAddress
(useKeyPair.getAccountId
)This PR diff is quite hard to read so I created a javadoc for the changed API. It can be found here: http://bartekn.github.io/java-stellar-sdk-proposal-doc/
Breaking changes
This changes will be released as version
0.1.0
. We will support0.0.*
versions of sdk and base for unspecified amount of time (we will disclose it after merging this PR) while encouraging integrators to switch to version0.1.0
.