Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Bumps minimum Golang version to 1.18 #4499

Merged
merged 5 commits into from
Aug 10, 2022

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Aug 2, 2022

What

Go 1.19 is out, so we should support 1.18 and 1.19.

Why

We support the two latest stable Golang versions.

Known limitations

n/a

@Shaptic Shaptic requested review from leighmcculloch and a team August 2, 2022 17:57
@Shaptic
Copy link
Contributor Author

Shaptic commented Aug 2, 2022

Ew wtf who approved this go fmt change

@Shaptic Shaptic force-pushed the go-bump-v1.19 branch 2 times, most recently from 4b868f7 to 3f57ddc Compare August 9, 2022 20:45
@Shaptic
Copy link
Contributor Author

Shaptic commented Aug 9, 2022

lol awesome, ./gofmt.sh and ./gogenerate.sh are now incompatible with each other because of this change 😒 investigating...

@Shaptic
Copy link
Contributor Author

Shaptic commented Aug 9, 2022

Awesome, looks like azure.archive.ubuntu.com is down:

Err:1 http://azure.archive.ubuntu.com/ubuntu focal/universe amd64 git-restore-mtime all 2019.11-1
  Could not connect to azure.archive.ubuntu.com:80 (52.252.75.106), connection timed out
E: Failed to fetch http://azure.archive.ubuntu.com/ubuntu/pool/universe/g/git-mestrelion-tools/git-restore-mtime_2019.11-1_all.deb  Could not connect to azure.archive.ubuntu.com:80 (52.252.75.106), connection timed out
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Error: Process completed with exit code 100.

@Shaptic Shaptic enabled auto-merge (squash) August 10, 2022 17:14
@Shaptic Shaptic requested a review from leighmcculloch August 10, 2022 17:23
@Shaptic Shaptic merged commit 9d5b585 into stellar:master Aug 10, 2022
@Shaptic Shaptic deleted the go-bump-v1.19 branch August 10, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants