txnbuild: Reinstate missing fee bump transaction functions #3199
Conversation
tamirms
force-pushed
the
feebump-txnbuild-fix
branch
from
fdbb1d5 to
50efba2
Compare
| newTx := new(FeeBumpTransaction) | ||
| *newTx = *t | ||
| newTx.signatures = extendedSignatures |
There was a problem hiding this comment.
I know you're just reinstating missing functionality, but can I ask what this is doing? Is this like a Go-idiomatic way to copy a struct?
There was a problem hiding this comment.
in Go the assignment operator copies by value. However, the assignment operator does a shallow copy. If you have any pointers or slices in your structs, the new struct will still have references to those fields. Here's an article which provides more details on this topic https://flaviocopes.com/go-copying-structs/
In this particular case, the signatures field is the only mutable field in the struct. There are no exported functions on FeeBumpTransaction or Transaction which modify any of the other fields in the struct. The code creates a copy of the FeeBumpTransaction struct via assignment and then it does a deep copy on the signatures slice.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
A few functions on the fee bump transaction struct were unintentionally removed in https://github.com/stellar/go/pull/3048/files
This commit reinstates those deleted functions and adds tests for the functions to prevent them from being deleted accidentally again.