Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

txnbuild: add support for ManageBuyOffer #1274

Merged
merged 2 commits into from
May 15, 2019
Merged

txnbuild: add support for ManageBuyOffer #1274

merged 2 commits into from
May 15, 2019

Conversation

poliha
Copy link
Contributor

@poliha poliha commented May 14, 2019

This PR adds support for building ManageBuyOffer operations.
Closes #1165

@poliha poliha added the txnbuild 2nd-generation transaction build library for Go SDK label May 14, 2019
@poliha poliha added this to the txnbuild v1.2.0 milestone May 14, 2019
ire-and-curses
ire-and-curses approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks good!

@poliha poliha merged commit 7aca218 into release-txnbuild-v1.2.0 May 15, 2019
@poliha poliha deleted the txnbuild-manage-buy-offer branch May 15, 2019 09:23
@ire-and-curses ire-and-curses mentioned this pull request May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ire-and-curses ire-and-curses ire-and-curses approved these changes

@bartekn bartekn Awaiting requested review from bartekn

@debnil debnil Awaiting requested review from debnil

Assignees
No one assigned
Labels
txnbuild 2nd-generation transaction build library for Go SDK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poliha @ire-and-curses