Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon/ingest: new metric label for bytes-downloaded on history archive metrics #5186

Closed
sreuland opened this issue Jan 30, 2024 · 3 comments
Closed

services/horizon/ingest: new metric label for bytes-downloaded on history archive metrics #5186

sreuland opened this issue Jan 30, 2024 · 3 comments
Assignees
@Shaptic
Labels
cdp-horizon-scrum horizon performance issues aimed at improving performance

Comments

@sreuland
Copy link
Contributor

What problem does your feature solve?

bytes downloaded per HA server is not captured in metrics, just count of download attempts

What would you like to see?

bytes_downloaded label added tohistory_archive_stats_total , grouped per source label, i.e an individual HA server

What alternatives are there?
@sreuland sreuland moved this from Backlog to Next Sprint Proposal in Platform Scrum Jan 30, 2024
@Shaptic
Copy link
Contributor

Shaptic commented Jan 30, 2024

Great call to captive this in an issue, and bytes_cached would be really useful as a comparison.

@mollykarcher mollykarcher added performance issues aimed at improving performance and removed feature request labels Jan 31, 2024
@sreuland
Copy link
Contributor Author

@Shaptic , i think this ticket can be closed, looks like implemented on #5197, want to add retro points?

@sreuland sreuland mentioned this issue Feb 13, 2024
Merged
@sreuland sreuland moved this from Next Sprint Proposal to Done in Platform Scrum Feb 13, 2024
@Shaptic
Copy link
Contributor

Shaptic commented Feb 13, 2024

Nice catch @sreuland! Done - I think 2 points is reasonable to cover code + test + grafana work?

@Shaptic Shaptic closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shaptic Shaptic

Labels
cdp-horizon-scrum horizon performance issues aimed at improving performance
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Shaptic @mollykarcher @sreuland