Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: update config to use history archive urls from our entire quorum set #5164

Closed
1 of 4 tasks
mollykarcher opened this issue Jan 16, 2024 · 4 comments
Closed
1 of 4 tasks
Assignees
Labels
horizon performance issues aimed at improving performance

Comments

@mollykarcher
Copy link
Contributor

mollykarcher commented Jan 16, 2024

What problem does your feature solve?

See parent epic: #5163

In puppet, we currently set history_archive_urls to a single validator on our Horizon instances.

What would you like to see?

We should set history_archive_urls to be a list/collection of history urls from all of the validators in the quorum set which is defined in the same config.

Horizon is set up to handle pooling of archives and random access across said pool of archives. However, given that this has always set up to be 1 in our infrastructure, we should take the time to ensure this is working as expected once done. In particular:

@sreuland
Copy link
Contributor

@mollykarcher , to confirm, do we want to include all other external non-sdf validator servers from qset in horizon history_archive_urls , or just limit this to include the 3 SDF validator history servers?

@mollykarcher
Copy link
Contributor Author

@sreuland yes, we want to include all validators that are configured in our qset

@sreuland sreuland moved this from Current Sprint to In Progress in Platform Scrum Jan 17, 2024
@sreuland
Copy link
Contributor

further discussion, the scope on this is refined a bit:

  • reconfig archive urls for just the three hosted archive servers from the three respective validators -
  • defer to historyarchive: Harden the ArchivePool to be robust against errors.  #5167 for the other hardening aspects mentioned in description
  • this ticket scope will focus on changing staging and in-active clusters first, monitor to confirm changes are fine
  • do a second puppet pr to change the active cluster

@sreuland
Copy link
Contributor

moving to in review as puppet pr/3642 is up for review

@sreuland sreuland moved this from In Progress to Needs Review in Platform Scrum Jan 18, 2024
@jacekn jacekn closed this as completed Jan 25, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
horizon performance issues aimed at improving performance
Projects
Status: Done
Development

No branches or pull requests

2 participants