-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services/horizon: Introduce "show-default-network" command in Horizon #4954
Comments
In the context of this ticket, the term "network-quorum set" refers to the list of validator names along with their addresses and history urls, as configured in the captive-core config file. The main objective is to simplify Horizon setup by displaying the URLs that users should consider adding to their firewall rules, without the need to manually inspect the captive-core config file. Originally, the plan was to implement There are two possible options to move forward: Option 1: Option 2: @mollykarcher, What are your thoughts on the best approach to move forward? |
I would vote for option 2, a minor suggestion for simiplification of the sub-cmd to I think option 1 is cool, if it resonates, maybe we add that in another iteration, the one caveat with that is that you have to install horizon first, before can retrieve the list of quorum hosts, which is the chicken/egg thing as a typical deployment timeline will want to identify fw rules for outbound traffic up front first before running the system. |
Amongst those options, I would agree that Option 2 sounds like our best option right now. Though I may change the name subtlety to make it super-explicit it's purpose (ie. However, I actually would question whether or not we really need this command. You can still get this info in viewing the generated file, though I get that might be annoying. Given that, my inclination would be to not add it now, but to add it later, should the need arise or if we notice user pain around it. |
I think the generated captive core config file won't be available until horizon has been run in the 'serve' or 'ingest' mode at least once, it seems like that type of cycle was where |
What problem does your feature solve?
Add an option in Horizon to list the hosts that horizon and captive core will initiate outbound tcp/ip connections based on the NETWORK type, includes hosts from core's quorum set and archive urls.
This feature is part of the recent addition of the NETWORK parameter, which simplifies the process of starting Horizon with Stellar networks (#4913). With that update, Horizon will automatically utilize the default configuration for the selected network and generates the captive core config file.
Adding
show-default-network
command will allow users to view the list of hosts in the network quorum and the lists of hosts in the archive urls list, enabling them to configure firewalls and other settings accordingly.What would you like to see?
Add a new command to Horizon called
show-default-network
, which allows users to view the generated quorum set for the chosen Stellar network.Usage:
stellar-horizon --show-default-network [testnet|pubnet]
Running this command will display two lists: the hosts in the network quorum and the hosts in the archive urls list. The output format of the command is TBD.
What alternatives are there?
users manually open the generated captive core .cfg file that horizon places on disk when using NETWORK and after ingestion has started, get the quorum set from that.
The text was updated successfully, but these errors were encountered: