Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: remove remote captive core #4823

Closed
mollykarcher opened this issue Mar 28, 2023 · 1 comment
Closed

services/horizon: remove remote captive core #4823

mollykarcher opened this issue Mar 28, 2023 · 1 comment

Comments

@mollykarcher
Copy link
Contributor

What problem does your feature solve?

Remote captive core is currently publicized in our docs, but we do not maintain it or test it when we do releases. It has not kept up with feature development on main line (ex. on-disk mode), and we do not dogfood it ourselves so are unaware of any potential bugs or operational issues (ex. recent issue with metrics endpoint).

What would you like to see?

  • Remove the configuration options / env variables for it
  • Remove all functionality and codepaths associated with it
  • Remove any reference to it or mention of it in public-facing documentation

What alternatives are there?

  1. Start maintaining + testing it so that we can confidently document and recommend it. I don't see this option being worthwhile as I find it unlikely anyone is actually using this option, and we don't have a solid use case for it internally
  2. Don't remove it from code, just remove it from public-facing documentation. This could still achieve the goal of dissuading people from using it, but it would still be available if they were currently using it
  3. Remove it from code, but leave mention of it (and it's deprecation) in public-facing documentation. This could be useful for anyone that was currently using it and give them a clear path as to how to migrate away from it
  4. Don't remove it from code or documentation, but change the existing documentation disclaimer about it being experimental to make it clear that it is not maintained at all and to use at your own risk. This is probably the quickest and safest option that achieves the end goal
@mollykarcher mollykarcher changed the title Remove remote captive core services/horizon: remove remote captive core Mar 28, 2023
@Shaptic
Copy link
Contributor

Shaptic commented Mar 29, 2023

I support (2), since it's still a useful piece of code (even if it needs some maintenance), because it already lives in the exp/ (as in experimental) folder which should imply that its usage is risky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants