-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
horizon: change SAC to add supportive ingestion data #4747
Comments
every emitted event includes asset id in event body. |
As far as I can tell (add'l context here: #4725 (comment)), there's no definitive way to know that an event came from a SAC without storing the SACs themselves. Otherwise you open yourself up to "SAC-like events" spoofing their behavior. |
I think that Tamir suggested a way to do that without storing the SAC. ( I don't have the link to the PR ) |
I believe you're referencing stellar/rs-soroban-env#686; I'll move my concerns there 👍 |
fixed in stellar/rs-soroban-env#705 |
What ?
We need to modify the SAC code to add information to the emitted events that would inform us if that's a SAC or not.
This task is a prerequisite for several of the horizon ingestion support for SAC.
master issue: #4722
( this ticket is a placeholder; clearly, any change to the SAC is not going to be implemented within this repository )
The text was updated successfully, but these errors were encountered: