Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

horizon: change SAC to add supportive ingestion data #4747

Closed
tsachiherman opened this issue Jan 24, 2023 · 5 comments
Closed

horizon: change SAC to add supportive ingestion data #4747

tsachiherman opened this issue Jan 24, 2023 · 5 comments
Assignees

Comments

@tsachiherman
Copy link
Contributor

tsachiherman commented Jan 24, 2023

What ?

We need to modify the SAC code to add information to the emitted events that would inform us if that's a SAC or not.
This task is a prerequisite for several of the horizon ingestion support for SAC.

master issue: #4722

( this ticket is a placeholder; clearly, any change to the SAC is not going to be implemented within this repository )

@sreuland
Copy link
Contributor

every emitted event includes asset id in event body.

@paulbellamy paulbellamy moved this from Next Sprint Proposal to Current Sprint in Platform Scrum Jan 31, 2023
@tamirms tamirms assigned tamirms and unassigned tamirms Feb 2, 2023
@tamirms tamirms self-assigned this Feb 14, 2023
@tamirms tamirms moved this from Current Sprint to In Progress in Platform Scrum Feb 14, 2023
@tamirms tamirms moved this from In Progress to Needs Review in Platform Scrum Feb 14, 2023
@Shaptic
Copy link
Contributor

Shaptic commented Feb 22, 2023

As far as I can tell (add'l context here: #4725 (comment)), there's no definitive way to know that an event came from a SAC without storing the SACs themselves. Otherwise you open yourself up to "SAC-like events" spoofing their behavior.

@tsachiherman
Copy link
Contributor Author

As far as I can tell (add'l context here: #4725 (comment)), there's no definitive way to know that an event came from a SAC without storing the SACs themselves. Otherwise you open yourself up to "SAC-like events" spoofing their behavior.

I think that Tamir suggested a way to do that without storing the SAC. ( I don't have the link to the PR )

@Shaptic
Copy link
Contributor

Shaptic commented Feb 22, 2023

I believe you're referencing stellar/rs-soroban-env#686; I'll move my concerns there 👍

@tamirms tamirms moved this from Needs Review to Blocked in Platform Scrum Feb 24, 2023
@tamirms
Copy link
Contributor

tamirms commented Feb 25, 2023

fixed in stellar/rs-soroban-env#705

@tamirms tamirms closed this as completed Feb 25, 2023
@github-project-automation github-project-automation bot moved this from Blocked to Done in Platform Scrum Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants