Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exp/lighthorizon: Properly serialize transaction records to JSON. #4527

Closed
Shaptic opened this issue Aug 9, 2022 · 1 comment
Closed

exp/lighthorizon: Properly serialize transaction records to JSON. #4527

Shaptic opened this issue Aug 9, 2022 · 1 comment
Assignees
@Shaptic

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Aug 9, 2022 •
edited
Loading

Horizon Lite Epic: #4317.

We need the transaction response objects in Light Horizon to mirror the existing ones in order to effectively perform comparisons between them.

This involves modifying ./adapters/transaction.go to mirror the way services/horizon/internal/resourceadapter/transaction.go::PopulateTransaction translates the data into JSON.
@Shaptic Shaptic self-assigned this Aug 9, 2022
@Shaptic Shaptic mentioned this issue Aug 11, 2022
Merged
@Shaptic
Copy link
Contributor Author

Shaptic commented Aug 31, 2022

This was closed by #4531.

@Shaptic Shaptic closed this as completed Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shaptic Shaptic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Shaptic