Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message after Stellar-Core crash #4255

Closed
bartekn opened this issue Mar 3, 2022 · 2 comments · Fixed by #4893
Closed

Improve error message after Stellar-Core crash #4255

bartekn opened this issue Mar 3, 2022 · 2 comments · Fixed by #4893
Assignees
@urvisavla
Labels
bug horizon

Comments

@bartekn
Copy link
Contributor

bartekn commented Mar 3, 2022 •
edited
Loading

Currently, when Stellar-Core crashes when preparing a new range it logs the following error message:

error preparing range: Error fast-forwarding to 17089856: error reading frame length: unmarshalling XDR frame header: xdr:DecodeUint: EOF while decoding 4 bytes - read: '[]'

This is really confusing. We should improve this message and, if possible, log the latest error level message from Stellar-Core.
@bartekn bartekn modified the milestone: Horizon 2.5.0 Mar 3, 2022
@2opremio
Copy link
Contributor

2opremio commented Mar 3, 2022

Related #4066

@bartekn
Copy link
Contributor Author

bartekn commented Mar 3, 2022

#4066

Yeah, looks like there's another place in the code we aren't doing this properly.

This was referenced Apr 6, 2022
Closed
Closed
@sreuland sreuland mentioned this issue Jun 30, 2022
Merged
@sreuland sreuland moved this to Backlog in Platform Scrum Sep 1, 2022
@mollykarcher mollykarcher moved this from Backlog to In Progress in Platform Scrum Mar 9, 2023
@mollykarcher mollykarcher moved this from In Progress to Backlog in Platform Scrum Mar 9, 2023
@urvisavla urvisavla self-assigned this May 22, 2023
@mollykarcher mollykarcher moved this from Backlog to Current Sprint in Platform Scrum May 24, 2023
@urvisavla urvisavla moved this from Current Sprint to In Progress in Platform Scrum Jun 6, 2023
@urvisavla urvisavla mentioned this issue Jun 14, 2023
Merged
7 tasks
@urvisavla urvisavla moved this from In Progress to Needs Review in Platform Scrum Jun 14, 2023
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Platform Scrum Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@urvisavla urvisavla

Labels
bug horizon
Projects
Platform Scrum
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

services/horizon: Improve error handling for when stellar-core crashes urvisavla/go
3 participants
@bartekn @2opremio @urvisavla