Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: claimable balances endpoint lacks cursor and limit parameters #4103

Closed
charlie-wasp opened this issue Nov 29, 2021 · 1 comment · Fixed by #4145
Closed
Assignees
Labels
bug horizon horizon-api Issues or features related to the Horizon API small fix

Comments

@charlie-wasp
Copy link
Contributor

charlie-wasp commented Nov 29, 2021

What version are you using?

Horizon 2.11.0-07dcbb1e43d9ee991461e1284af1d11dcae645d7

What did you do?

I noticed, that cursor and limit parameters are not listed for /claimable_balances endpoint on https://horizon.stellar.org. It doesn't affect direct queries, but it breaks HAL-compatible clients, such as Hyperclient

What did you expect to see?

"claimable_balances": {
  "href": "https://horizon.stellar.org/claimable_balances?{cursor,limit,asset,claimant,sponsor}",
  "templated": true
}

What did you see instead?

"claimable_balances": {
  "href": "https://horizon.stellar.org/claimable_balances?{asset,claimant,sponsor}",
  "templated": true
}

I would be happy to help with PR, if such behaviour is not intended

@charlie-wasp
Copy link
Contributor Author

Also, it seems that overall syntax is wrong, question mark should be inside curly braces, like {?asset, ...}

@leighmcculloch leighmcculloch changed the title Claimable balances endpoint lacks cursor and limit parameters services/horizon: claimable balances endpoint lacks cursor and limit parameters Nov 29, 2021
@leighmcculloch leighmcculloch added horizon horizon-api Issues or features related to the Horizon API labels Nov 29, 2021
@2opremio 2opremio self-assigned this Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug horizon horizon-api Issues or features related to the Horizon API small fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants