Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMM integration tests #3842

Closed
2opremio opened this issue Aug 24, 2021 · 2 comments · Fixed by #3868 or #3890
Closed

Add AMM integration tests #3842

2opremio opened this issue Aug 24, 2021 · 2 comments · Fixed by #3868 or #3890
Assignees
Labels
amm support cap 38 (automated market makers) in horizon

Comments

@2opremio
Copy link
Contributor

2opremio commented Aug 24, 2021

The tests should cover:

  • The full lifecycle of a liquidity pool: creation, deposit, withdrawal, trading, removal and revocation
  • All the new liquidity pool effects
  • All the updated effects (due to the introduction of the liquidity pools)
  • Fetching the new liquidity pool operations (deposit and withdraw)
  • Querying all the new liquidity pool endpoints (e.g. liquidity pools, effects, by liquidity pool, operations by liquidity pool, transactions by liquidity pool).
  • Path payments (send and receive) through a liquidity pool.

In order to run the tests we should update CircleCI to:

  • Incorporate new jobs to run protocol 18 integration tests. You can see an example at [CAP 35] Separate CAP35 tests (so that we can merge cap35 to master) #3452 . Instead of using a protocol-specific name for the jobs we should probably use a more generic name (e.g. next_protocol) because we will be using separate integration tests for the future protocol releases.
  • Those jobs Core with protocol 18 support (which requires a Core debian package and docker image built with --enable-next-protocol-version-unsafe-for-production ).
@2opremio 2opremio added the amm support cap 38 (automated market makers) in horizon label Aug 24, 2021
@bartekn bartekn self-assigned this Aug 26, 2021
@bartekn bartekn linked a pull request Aug 30, 2021 that will close this issue
7 tasks
@bartekn
Copy link
Contributor

bartekn commented Aug 31, 2021

Most cases handled in #3868. Going to add revoke case when stellar/stellar-core#3162 is merged.

@bartekn bartekn removed their assignment Sep 3, 2021
@bartekn
Copy link
Contributor

bartekn commented Sep 3, 2021

Image updated with new changes so this is no longer blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amm support cap 38 (automated market makers) in horizon
Projects
None yet
2 participants