Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix separation of concerns in Horizon processors #3196

Open
6 of 14 tasks
bartekn opened this issue Nov 6, 2020 · 0 comments
Open
6 of 14 tasks

Fix separation of concerns in Horizon processors #3196

bartekn opened this issue Nov 6, 2020 · 0 comments

Comments

@bartekn
Copy link
Contributor

bartekn commented Nov 6, 2020

Currently, many Horizon processors are relying on db2/history package to do parts of ingestion. db2/history methods should be dumb: they should accept struct to insert/update in a DB and do nothing else. Doing this will make code and tests simpler and will allow writing fuzzers with a mocked DBs.

While working on this we can fix existing issues related to using maps instead of structs: #2578.

Examples:

List of processors to fix:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants