Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add Protocol 14 examples to docstrings #3120

Closed
Shaptic opened this issue Oct 9, 2020 · 0 comments · Fixed by #3165
Closed

services/horizon: Add Protocol 14 examples to docstrings #3120

Shaptic opened this issue Oct 9, 2020 · 0 comments · Fixed by #3165
Assignees
Labels
feature request txnbuild 2nd-generation transaction build library for Go SDK

Comments

@Shaptic
Copy link
Contributor

Shaptic commented Oct 9, 2020

Per @ire-and-curses, we (I) need to update the doc-strings to include examples for the new operations introduced in Protocol 14, much like the unit-testable examples for existing operations (e.g. Payment). This includes:

  • create claimable balance
  • claim claimable balance
  • begin/end sponsoring future reserves
  • revoke sponsorship

It should be straightforward to adapt them from the official SDK examples (e.g. these for the latter two ops) in the new docs.

@Shaptic Shaptic self-assigned this Oct 9, 2020
@ire-and-curses ire-and-curses added the txnbuild 2nd-generation transaction build library for Go SDK label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request txnbuild 2nd-generation transaction build library for Go SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants