json: cannot unmarshal number into Go struct field RevokeSponsorship.offer_id of type string

[bartekn]

What version are you using?

1.9.0

What did you do?

Found this transaction when checking the logs:
https://horizon-protocol14.stellar.org/transactions/36c0f3aaf915667f3a15ef2bba2df4496f17a78e82112e58d26deef6dc203957 it's /operations return 500:
https://horizon-protocol14.stellar.org/transactions/36c0f3aaf915667f3a15ef2bba2df4496f17a78e82112e58d26deef6dc203957/operations
and the following error:

json: cannot unmarshal number into Go struct field RevokeSponsorship.offer_id of type string

[bartekn]

OK, I think it was fixed in #3072. @2opremio you can close this if it's the same bug.

[2opremio]

I do think it's the same bug but... could you test on testnet to be sure?

[bartekn]

The problem is here. We save the offer_id as string:

go/services/horizon/internal/expingest/processors/operations_processor.go

Line 492 in 47e9c16

result["offer_id"] = fmt.Sprintf("%d", ledgerKey.Offer.OfferId)

but then it's unmarshaled into int64:

go/protocols/horizon/operations/main.go

Line 259 in 47e9c16

OfferID *int64 `json:"offer_id,omitempty,string"`

[2opremio]

@bartekn note the string tag (i.e. it will accept a string even if it's an int64). I tested it.

Also, you were testing it on the 1.9 RC and not on the the GA release. I do think it's the same bug but I will eat my hat if you reproduce it on testnet (with the 1.9 final release)

[2opremio]

PS: it's being tested at

go/services/horizon/internal/integration/protocol14_sponsorship_ops_test.go

Line 829 in 8535626

tt.Equal(offer.ID, *revokeOp.OfferID)

[abuiles]

@2opremio @bartekn I smoke test this in testnet and the problem is fixed - https://horizon-testnet.stellar.org/transactions/02a69bb0dc83d004ae918aab2d10c9dbc2cbf4451ab12927a691b87e5c6c5079/operations

The string tag @2opremio pointed above does the right thing and also the PR where the fixed was introduced mentions this specific scenario: * Fix type for RevokeSponsorship's OfferID field, which was causing a 500 error on /operations due to an unmarshalling error.

[bartekn]

@abuiles thanks for checking!