Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TypeNames for OperationTypePathPaymentStrictReceive, OperationTypeManageSellOffer, and OperationTypeCreatePassiveSellOffer #2131

Closed
abuiles opened this issue Jan 16, 2020 · 1 comment
Closed

Update TypeNames for OperationTypePathPaymentStrictReceive, OperationTypeManageSellOffer, and OperationTypeCreatePassiveSellOffer #2131

abuiles opened this issue Jan 16, 2020 · 1 comment
Assignees
@abuiles
Labels
feature request
Milestone
Horizon 1.0-alpha

Comments

@abuiles
Copy link
Contributor

abuiles commented Jan 16, 2020

Update the values for TypeNames to match the following deprecations:

go/protocols/horizon/operations/main.go

Lines 19 to 27 in 2a7c16b

// Action needed in release: horizon-v0.25.0
// Change name to `path_payment_strict_receive`
xdr.OperationTypePathPaymentStrictReceive: "path_payment",
// Action needed in release: horizon-v0.25.0
// Change name to `manage_sell_offer`
xdr.OperationTypeManageSellOffer: "manage_offer",
// Action needed in release: horizon-v0.25.0
// Change name to `create_passive_sell_offer`
xdr.OperationTypeCreatePassiveSellOffer: "create_passive_offer",

@abuiles abuiles added this to the Horizon 0.25.0 milestone Jan 16, 2020
@abuiles abuiles self-assigned this Jan 16, 2020
@abuiles
Copy link
Contributor Author

abuiles commented Jan 20, 2020

Fixed on #2134

@abuiles abuiles closed this as completed Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abuiles abuiles

Labels
feature request
Projects
None yet
Milestone
Horizon 1.0-alpha
Development

No branches or pull requests
1 participant
@abuiles