Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change StateReader to StateReadCloser #1309

Closed
bartekn opened this issue May 17, 2019 · 0 comments · Fixed by #1264
Closed

Change StateReader to StateReadCloser #1309

bartekn opened this issue May 17, 2019 · 0 comments · Fixed by #1264
Labels
ingest New ingestion system

Comments

@bartekn
Copy link
Contributor

bartekn commented May 17, 2019

We should change StateReader to StateReadCloser (like ReadCloser) so basically add Close() err method. Consumers should always call Close() when reading is done so reader can close channels, connections, etc. internally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ingest New ingestion system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

exp/ingest: Ingest pipeline prototype stellar/go
1 participant
@bartekn