Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/horizon: Add full pagination to Orderbooks endpoint #1230

Open
accordeiro opened this issue May 2, 2019 · 0 comments
Open

services/horizon: Add full pagination to Orderbooks endpoint #1230

accordeiro opened this issue May 2, 2019 · 0 comments
Labels
horizon horizon-api Issues or features related to the Horizon API

Comments

@accordeiro
Copy link
Member

As per discussion on #1193 (comment), the orderbook details endpoint currently supports a limit parameter, but pagination is not provided. We should add full pagination support to this endpoint as well.

It's important to highlight that this endpoint is used by many services, so we should try to keep the changes backwards compatible if possible.
@accordeiro accordeiro mentioned this issue May 2, 2019
Merged
@ire-and-curses ire-and-curses added the horizon-api Issues or features related to the Horizon API label Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
horizon horizon-api Issues or features related to the Horizon API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ire-and-curses @accordeiro