diff --git a/README.md b/README.md index 8a5e67a7be..0c4054f1c1 100644 --- a/README.md +++ b/README.md @@ -7,6 +7,8 @@ This repo is the home for all of the public go code produced by SDF. In additio ## Dependencies +*NOTE: this repo presently uses a fork of govalidator that incorporates https://github.com/asaskevich/govalidator/pull/165. Vendored dependencies must be restored (using `glide install`) to get proper behaviour. In other words, this repo is not currently "go gettable"* + This repository depends upon a [number of external dependencies](./glide.yaml), and we use [Glide](https://glide.sh/) to manage them. Glide is used to populate the [vendor directory](http://glide.readthedocs.io/en/latest/vendor/), ensuring that builds are reproducible even as upstream dependencies are changed. Please see the [Glide](http://glide.sh/) website for installation instructions. When creating this project, we had to decide whether or not we committed our external dependencies to the repo. We decided that we would not, by default, do so. This lets us avoid the diff churn associated with updating dependencies while allowing an acceptable path to get reproducible builds. To do so, simply install glide and run `glide install` in your checkout of the code. We realize this is a judgement call; Please feel free to open an issue if you would like to make a case that we change this policy. diff --git a/glide.lock b/glide.lock index e348b800f1..647db693aa 100644 --- a/glide.lock +++ b/glide.lock @@ -1,5 +1,5 @@ -hash: 16fe0b731a9a76e736f87e7f34179ad3ccd2dc577a95067f5c39f035ee350e79 -updated: 2016-08-30T14:06:41.303176771-07:00 +hash: 805bc7accf5266e737482b8bff09ee04c554d404e3daecb1d84e7086277dbe70 +updated: 2016-11-10T15:52:55.78656724-08:00 imports: - name: github.com/agl/ed25519 version: 278e1ec8e8a6e017cd07577924d6766039146ced @@ -8,7 +8,8 @@ imports: - name: github.com/ajg/form version: cc2954064ec9ea8d93917f0f87456e11d7b881ad - name: github.com/asaskevich/govalidator - version: 593d64559f7600f29581a3ee42177f5dbded27a9 + version: f0666aa80d7dcf75bd564ae8717b952d74a29d6a + repo: https://github.com/stellar/govalidator.git - name: github.com/aws/aws-sdk-go version: 35c21ff262580265c1d77095d6f712605fd0c3f4 subpackages: diff --git a/glide.yaml b/glide.yaml index 8cdec5ee01..65a9826827 100644 --- a/glide.yaml +++ b/glide.yaml @@ -21,6 +21,7 @@ import: - package: github.com/rs/cors - package: goji.io - package: github.com/asaskevich/govalidator + repo: https://github.com/stellar/govalidator.git - package: github.com/BurntSushi/toml - package: github.com/spf13/cobra - package: gopkg.in/gavv/httpexpect.v1 diff --git a/support/config/broken_test.go b/support/config/broken_test.go index e14541dfcc..e4b0384653 100644 --- a/support/config/broken_test.go +++ b/support/config/broken_test.go @@ -1,5 +1,3 @@ -// +build brokentests - package config import (