From 4a9f86db1276531b11d77e86f25e319a87fdf716 Mon Sep 17 00:00:00 2001 From: Bartek Nowotarski Date: Wed, 10 Aug 2022 09:37:13 +0200 Subject: [PATCH] Improve test --- services/horizon/internal/ingest/main_test.go | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/services/horizon/internal/ingest/main_test.go b/services/horizon/internal/ingest/main_test.go index 49694f0a45..fab435055b 100644 --- a/services/horizon/internal/ingest/main_test.go +++ b/services/horizon/internal/ingest/main_test.go @@ -162,7 +162,7 @@ func TestStateMachineRunReturnsErrorWhenNextStateIsShutdownWithError(t *testing. assert.EqualError(t, err, "invalid range: [0, 0]") } -func TestMaybeVerifyStateGetExpStateInvalidDBErrCancelOrContextCanceled(t *testing.T) { +func TestMaybeVerifyStateGetExpStateInvalidError(t *testing.T) { historyQ := &mockDBQ{} system := &system{ historyQ: historyQ, @@ -180,13 +180,21 @@ func TestMaybeVerifyStateGetExpStateInvalidDBErrCancelOrContextCanceled(t *testi defer func() { log = oldLogger }() historyQ.On("GetExpStateInvalid", system.ctx).Return(false, db.ErrCancelled).Once() - system.maybeVerifyState(0) + system.maybeVerifyState(63) + system.wg.Wait() historyQ.On("GetExpStateInvalid", system.ctx).Return(false, context.Canceled).Once() - system.maybeVerifyState(0) + system.maybeVerifyState(63) + system.wg.Wait() logged := done() assert.Len(t, logged, 0) + + // Ensure state verifier does not start also for any other error + historyQ.On("GetExpStateInvalid", system.ctx).Return(false, errors.New("my error")).Once() + system.maybeVerifyState(63) + system.wg.Wait() + historyQ.AssertExpectations(t) } func TestMaybeVerifyInternalDBErrCancelOrContextCanceled(t *testing.T) {