-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation for XDR fields with limits #1
Comments
This looks like it belongs in |
You both are right. It looks like |
@tomquisel can you transfer this issue using "Transfer issue" feature? It's only available for admins. Has to be moved to |
@bartekn done! Issues were disabled for |
Fields like
xdr.SetOptionsOp.HomeDomain
have restrictions on size, but at run-time nothing prevents them from being set too large, which causestransaction_malformed
errors.It looks like the XDR library has defined sizes which can be checked (e.g. this one for
homeDomain
strings). They just need to be checked.@bartekn Does that sound right to you?
The text was updated successfully, but these errors were encountered: