Skip to content
This repository has been archived by the owner on Jan 18, 2019. It is now read-only.

move code in src/Ledger to use proper sql wrapper instead of legacy sql wrapper #152

Open
MonsieurNicolas opened this issue Oct 24, 2014 · 3 comments

Comments

@MonsieurNicolas
Copy link
Contributor

old wrappers are encouraging the use of raw SQL instead of using binding, which is error prone and can lead to failed queries or SQL injections.

Legacy in that case means:
src/ripple_app/data/SqliteDatabase.cpp ( SqliteDatabase and SqliteStatement)

it seems that beast:sqdb does what we want, we should standardize on it.

@jedmccaleb
Copy link
Contributor

If we are going to use this please pull it out of beast. We will hopefully drop beast at some point.

@vinniefalco
Copy link

Or use the original, which supports different backends (like MySQL or Oracle)
http://soci.sourceforge.net/
beast is a much needed interface "firewall": rippled calls into beast, but not the other way around. This facilitates levelization:
http://www2.caret.cam.ac.uk/rsfwiki/Wiki.jsp?page=Levelization
This follows the principles in the Lakos' book:
"Large-Scale C++ Software Design"
http://www.amazon.com/gp/product/0201633620/002-7417214-8818440

@vinniefalco
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants