From 73508a46d43e8393e7bd5692bddb65e970b72675 Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Fri, 14 Apr 2023 10:21:25 -0700 Subject: [PATCH 01/12] Fix broken link in readme --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 939b6dd6..0092f6a4 100644 --- a/README.md +++ b/README.md @@ -42,7 +42,7 @@ More details in the [README](https://github.com/stellar/starlight/tree/main/exam ## Get involved -- [Discord](https://discord.gg/xGWRjyNzQh) +- [Discord](https://discord.gg/stellardev) - [Discussions](https://github.com/stellar/starlight/discussions) - [Demos](https://github.com/stellar/starlight/discussions/categories/demos) - [Getting Started](Getting%20Started.md) From 424ac78bb47cb9a9f1c9cb9e7ed9e4eb48255f81 Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Sat, 17 Jun 2023 09:52:13 -0700 Subject: [PATCH 02/12] update golangci-lint --- .github/workflows/sdk.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml index f4ecd184..5872ea88 100644 --- a/.github/workflows/sdk.yml +++ b/.github/workflows/sdk.yml @@ -18,7 +18,7 @@ jobs: with: go-version: 1 - name: golangci-lint - uses: golangci/golangci-lint-action@5c56cd6c9dc07901af25baab6f2b0d9f3b7c3018 + uses: golangci/golangci-lint-action@2dcd82f331c9e834f283075b23ef289435be9354 with: version: v1.45.2 working-directory: sdk From 2e55ad0d81668df29411e34c8e0cf68d829eaacc Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Fri, 23 Jun 2023 08:36:42 -0700 Subject: [PATCH 03/12] update golangci-lint --- .github/workflows/sdk.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml index 5872ea88..76ba5a19 100644 --- a/.github/workflows/sdk.yml +++ b/.github/workflows/sdk.yml @@ -18,9 +18,9 @@ jobs: with: go-version: 1 - name: golangci-lint - uses: golangci/golangci-lint-action@2dcd82f331c9e834f283075b23ef289435be9354 + uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 with: - version: v1.45.2 + version: v1.53.3 working-directory: sdk skip-go-installation: true From 01cde18d55dc15e0a28f7ec8d03ccd9f2a976bf0 Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Fri, 23 Jun 2023 08:51:24 -0700 Subject: [PATCH 04/12] disable gocritic due to ruleguard errors --- sdk/.golangci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sdk/.golangci.yml b/sdk/.golangci.yml index aecb582d..bbc85242 100644 --- a/sdk/.golangci.yml +++ b/sdk/.golangci.yml @@ -3,6 +3,8 @@ linters: enable: - gofmt - gofumpt + disable: + - gocritic linters-settings: govet: From dbcab98ef2862ca599c4372f9dd58e8187b5b096 Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Fri, 23 Jun 2023 08:54:03 -0700 Subject: [PATCH 05/12] lint --- .github/workflows/examples-console.yml | 5 ++--- .github/workflows/sdk.yml | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/examples-console.yml b/.github/workflows/examples-console.yml index e974aad7..f1ef67e3 100644 --- a/.github/workflows/examples-console.yml +++ b/.github/workflows/examples-console.yml @@ -18,11 +18,10 @@ jobs: with: go-version: 1 - name: golangci-lint - uses: golangci/golangci-lint-action@5c56cd6c9dc07901af25baab6f2b0d9f3b7c3018 + uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 with: - version: v1.45.2 + version: v1.53.3 working-directory: examples/console - skip-go-installation: true build: runs-on: ubuntu-latest diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml index 76ba5a19..309b22c8 100644 --- a/.github/workflows/sdk.yml +++ b/.github/workflows/sdk.yml @@ -22,7 +22,6 @@ jobs: with: version: v1.53.3 working-directory: sdk - skip-go-installation: true build: runs-on: ubuntu-latest From 132b7ae107b20948da5ed218af4ec6f444e36172 Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Tue, 5 Mar 2024 00:02:36 +1000 Subject: [PATCH 06/12] undo unrelated changes --- .github/workflows/examples-console.yml | 5 +++-- .github/workflows/sdk.yml | 5 +++-- sdk/.golangci.yml | 2 -- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/examples-console.yml b/.github/workflows/examples-console.yml index f1ef67e3..f2b31f6e 100644 --- a/.github/workflows/examples-console.yml +++ b/.github/workflows/examples-console.yml @@ -18,10 +18,11 @@ jobs: with: go-version: 1 - name: golangci-lint - uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 + uses: golangci/golangci-lint-action@5c56cd6c9dc07901af25baab6f2b0d9f3b7c3018 with: - version: v1.53.3 + version: v1.45.2 working-directory: examples/console +skip-go-installation: true build: runs-on: ubuntu-latest diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml index 309b22c8..4883c609 100644 --- a/.github/workflows/sdk.yml +++ b/.github/workflows/sdk.yml @@ -18,10 +18,11 @@ jobs: with: go-version: 1 - name: golangci-lint - uses: golangci/golangci-lint-action@639cd343e1d3b897ff35927a75193d57cfcba299 + uses: golangci/golangci-lint-action@5c56cd6c9dc07901af25baab6f2b0d9f3b7c3018 with: - version: v1.53.3 + version: v1.45.2 working-directory: sdk +skip-go-installation: true build: runs-on: ubuntu-latest diff --git a/sdk/.golangci.yml b/sdk/.golangci.yml index bbc85242..aecb582d 100644 --- a/sdk/.golangci.yml +++ b/sdk/.golangci.yml @@ -3,8 +3,6 @@ linters: enable: - gofmt - gofumpt - disable: - - gocritic linters-settings: govet: From b8f064edd15c034c28be8a685088051a2e9ad227 Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Tue, 5 Mar 2024 00:03:16 +1000 Subject: [PATCH 07/12] undo unrelated changes --- .github/workflows/examples-console.yml | 2 +- .github/workflows/sdk.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/examples-console.yml b/.github/workflows/examples-console.yml index f2b31f6e..e974aad7 100644 --- a/.github/workflows/examples-console.yml +++ b/.github/workflows/examples-console.yml @@ -22,7 +22,7 @@ jobs: with: version: v1.45.2 working-directory: examples/console -skip-go-installation: true + skip-go-installation: true build: runs-on: ubuntu-latest diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml index 4883c609..f4ecd184 100644 --- a/.github/workflows/sdk.yml +++ b/.github/workflows/sdk.yml @@ -22,7 +22,7 @@ jobs: with: version: v1.45.2 working-directory: sdk -skip-go-installation: true + skip-go-installation: true build: runs-on: ubuntu-latest From 4b48550598bbe131f41403e006dbf0990b6fbb5c Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Tue, 5 Mar 2024 00:06:55 +1000 Subject: [PATCH 08/12] disable ci for readme only updates --- .github/workflows/examples-console.yml | 4 ++++ .github/workflows/sdk.yml | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/.github/workflows/examples-console.yml b/.github/workflows/examples-console.yml index e974aad7..49c327ab 100644 --- a/.github/workflows/examples-console.yml +++ b/.github/workflows/examples-console.yml @@ -2,9 +2,13 @@ name: 'Examples: Console' on: push: + paths-ignore: + - 'README.md' branches: - main pull_request: + paths-ignore: + - 'README.md' jobs: diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml index f4ecd184..b60c1f42 100644 --- a/.github/workflows/sdk.yml +++ b/.github/workflows/sdk.yml @@ -2,9 +2,13 @@ name: SDK on: push: + paths-ignore: + - 'README.md' branches: - main pull_request: + paths-ignore: + - 'README.md' jobs: From 9a5aca4add51e8e294eeb99dfa98b6dc78132b9f Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Tue, 5 Mar 2024 00:07:52 +1000 Subject: [PATCH 09/12] Revert "disable ci for readme only updates" This reverts commit 4b48550598bbe131f41403e006dbf0990b6fbb5c. --- .github/workflows/examples-console.yml | 4 ---- .github/workflows/sdk.yml | 4 ---- 2 files changed, 8 deletions(-) diff --git a/.github/workflows/examples-console.yml b/.github/workflows/examples-console.yml index 49c327ab..e974aad7 100644 --- a/.github/workflows/examples-console.yml +++ b/.github/workflows/examples-console.yml @@ -2,13 +2,9 @@ name: 'Examples: Console' on: push: - paths-ignore: - - 'README.md' branches: - main pull_request: - paths-ignore: - - 'README.md' jobs: diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml index b60c1f42..f4ecd184 100644 --- a/.github/workflows/sdk.yml +++ b/.github/workflows/sdk.yml @@ -2,13 +2,9 @@ name: SDK on: push: - paths-ignore: - - 'README.md' branches: - main pull_request: - paths-ignore: - - 'README.md' jobs: From 2c8b81421a1ecafd8d29968d70fe21fbb39991f5 Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Tue, 5 Mar 2024 00:08:33 +1000 Subject: [PATCH 10/12] update golangci-lint --- .github/workflows/examples-console.yml | 2 +- .github/workflows/sdk.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/examples-console.yml b/.github/workflows/examples-console.yml index e974aad7..07085759 100644 --- a/.github/workflows/examples-console.yml +++ b/.github/workflows/examples-console.yml @@ -20,7 +20,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@5c56cd6c9dc07901af25baab6f2b0d9f3b7c3018 with: - version: v1.45.2 + version: v1.56.2 working-directory: examples/console skip-go-installation: true diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml index f4ecd184..56de350d 100644 --- a/.github/workflows/sdk.yml +++ b/.github/workflows/sdk.yml @@ -20,7 +20,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@5c56cd6c9dc07901af25baab6f2b0d9f3b7c3018 with: - version: v1.45.2 + version: v1.56.2 working-directory: sdk skip-go-installation: true From 8c74070bb93a56fd1984c4dbdbf554d3dd1bc1a4 Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Tue, 5 Mar 2024 00:13:22 +1000 Subject: [PATCH 11/12] lint fixes --- examples/console/stats.go | 2 +- sdk/state/doc.go | 20 ++++++++++---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/examples/console/stats.go b/examples/console/stats.go index a62a9a61..761a8e41 100644 --- a/examples/console/stats.go +++ b/examples/console/stats.go @@ -108,7 +108,7 @@ func (s *stats) AgreementsPerSecond() float64 { if timeFinish.IsZero() { timeFinish = time.Now() } - duration := s.timeFinish.Sub(s.timeStart) + duration := timeFinish.Sub(s.timeStart) rate := float64(s.agreementsSent+s.agreementsReceived) / duration.Seconds() if math.IsNaN(rate) || math.IsInf(rate, 0) { rate = 0 diff --git a/sdk/state/doc.go b/sdk/state/doc.go index a278b685..32f08785 100644 --- a/sdk/state/doc.go +++ b/sdk/state/doc.go @@ -18,16 +18,16 @@ The Open, Payment, and Close operations are broken up into three steps: - Finalize*: Called by the payer to finalize the agreement with the payees signatures. - +-----------+ +-----------+ - | Payer | | Payee | - +-----+-----+ +-----+-----+ - | | - Propose | - +----------------->+ - | Confirm - +<-----------------+ - Finalize* | - | | + +-----------+ +-----------+ + | Payer | | Payee | + +-----+-----+ +-----+-----+ + | | + Propose | + +----------------->+ + | Confirm + +<-----------------+ + Finalize* | + | | * Note that the Open and Close processes do not have a Finalize operation, and the Confirm is used in its place at this time. A Finalize operation is likely to be From 14b7252c7818c0fcd52e8e4733a2688641f7e574 Mon Sep 17 00:00:00 2001 From: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com> Date: Tue, 5 Mar 2024 07:22:42 +1000 Subject: [PATCH 12/12] fix integration tests --- .github/workflows/sdk.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/sdk.yml b/.github/workflows/sdk.yml index 56de350d..055a79ff 100644 --- a/.github/workflows/sdk.yml +++ b/.github/workflows/sdk.yml @@ -57,7 +57,7 @@ jobs: runs-on: ubuntu-latest steps: - name: "Stellar Quickstart: Run" - run: docker run -d -p 8000:8000 --name stellar stellar/quickstart --standalone --enable-core-artificially-accelerate-time-for-testing + run: docker run -d -p 8000:8000 --name stellar stellar/quickstart --local - name: "Stellar Quickstart: Wait for Ready" run: while ! [ "$(curl -s --fail localhost:8000 | jq '.history_latest_ledger')" -gt 0 ]; do echo waiting; sleep 1; done - name: "Stellar Quickstart: Details"