Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.

sdk/state: error if proposing or confirming a payment or close if channel open is authorized but not executed #235

Closed
leighmcculloch opened this issue Aug 17, 2021 · 2 comments · Fixed by #280
Assignees

Comments

@leighmcculloch
Copy link
Contributor

In #230 we added the capability to identify when the channel hasn't been authorized to be open, and blocking proposing or confirming any payments until that has occurred. When a channel is authorized to be open the channel hasn't actually opened until the open tx has been submitted to the network and the state of the accounts inspected after that to verify the channel is opened and safe to make payments on.

@acharb
Copy link
Contributor

acharb commented Aug 30, 2021

@leighmcculloch this is addressing the same as #261 correct? (looks like this was created first, didn't see it when I opened 261)

@leighmcculloch
Copy link
Contributor Author

This issue is new logic, error in conditions it currently doesn't error in. I thought #261 was a refactor, use the new state instead of interrogating other variables. So they seem like two different things. Maybe worth doing #261 first though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.