Skip to content
This repository has been archived by the owner on Nov 7, 2023. It is now read-only.

Add more detailed logs #152

Open
yuriescl opened this issue Jan 29, 2020 · 3 comments
Open

Add more detailed logs #152

yuriescl opened this issue Jan 29, 2020 · 3 comments

Comments

@yuriescl
Copy link

When clicking "Download logs", I get a log file with the same generic information displayed in the page.
It should contain more detailed logs.

For example, when the CORS header ‘Access-Control-Allow-Origin’ is missing, it just displays a TypeError: NetworkError when attempting to fetch resource. in both the webpage and the logs.

But in the browser console we can see a more detailed message: Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://<domain>/.well-known/stellar.toml. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing).

If possible, please add this kind of detailed message to the logs.

@msfeldstein
Copy link
Contributor

Unfortunately that is the one piece of detailed information we can't add (i wish we could!) the browsers don't allow you to see anything about CORS headers if CORS fails, this is for security purposes.

@msfeldstein
Copy link
Contributor

We can guess though, and if there's any network error put a note that says "Make sure CORS is enabled [..details]"

@yuriescl
Copy link
Author

@msfeldstein Another idea is to print the transaction (sent via postMessage by the popup) in the page, console or logs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants