Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Private keys should be able to be specified in environment variables #80

Closed
skirsch opened this issue Dec 13, 2018 · 2 comments
Closed

Comments

@skirsch
Copy link

skirsch commented Dec 13, 2018

// see sample feature request here: #2

Desired Behavior

// A succinct description of what you are trying to achieve that is not currently supported.
// This can be a request for a new plugin too (strategy, price feed, exchange).
// If your feature request is related to a problem with an existing feature then please submit a bug report instead.
// If this feature does not exist anywhere else then please restrict details to the Specification section below.

i want to spec private keys in environment variables and have script refer to that for specifying. Otherwise this is a disaster to have private keys in github.

Impact

// A succinct description of why you want the desired behavior specified above.

trading and source secret seed should allow me to reference an environment variable name, rather than just a string.

Feature Suggestion

// A succinct description of how you want to achieve the desired behavior.
// If you have looked at the code and know exactly what code changes are needed then please consider submitting a pull request instead.
// If this feature does not exist anywhere else then please restrict any details to the Specification section below.
trading and source secret seed should allow me to reference an environment variable name, rather than just a string

@nikhilsaraf
Copy link
Contributor

you should not be storing your private keys in github.
You should have 1 trader file per bot where you specify these keys. Would that approach work for you?

@nikhilsaraf
Copy link
Contributor

closing as discussed @skirsch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants