Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[ad-hoc] mirror strategy should prepend deleteOps before both bid and ask ops #501

Closed
nikhilsaraf opened this issue Sep 9, 2020 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nikhilsaraf
Copy link
Contributor

currently we prepend it at the beginning of each list and then combine the lists.
this is wrong because we could have the following order (few examples):

  • deleteSellOps, sellOps, deleteBuyOps, buyOps
  • sellOps, deleteBuyOps, buyOps
  • deleteBuyOps, buyOps, deleteSellOps, sellOps
  • buyOps, deleteSellOps, sellOps
  • buyOps, deleteSellOps

What we want is for something like this:

  • deleteSellOps, deleteBuyOps, sellOps, buyOps
  • deleteBuyOps, sellOps, buyOps
  • deleteBuyOps, deleteSellOps, buyOps, sellOps
  • deleteSellOps, buyOps, sellOps
  • deleteSellOps, buyOps
@nikhilsaraf nikhilsaraf added the bug Something isn't working label Sep 9, 2020
@nikhilsaraf nikhilsaraf added this to the v1.10.0 milestone Sep 9, 2020
@nikhilsaraf nikhilsaraf self-assigned this Sep 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant