Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[Epic] [8] streamline network requests #467

Closed
4 tasks done
nikhilsaraf opened this issue Aug 4, 2020 · 1 comment
Closed
4 tasks done

[Epic] [8] streamline network requests #467

nikhilsaraf opened this issue Aug 4, 2020 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nikhilsaraf
Copy link
Contributor

nikhilsaraf commented Aug 4, 2020

we are making too many network calls for basic information

See experimental profiling options added to binary in this commit (12ac3ce9d4d27acd57da0f9d6edeecdf671e1f4f)


Done in Sprint 5

  • [3] low-hanging fruit improvements to networking code that doesn't need redesign (issue)
  • [2] only reset cached balances and liabilities if pruneOps > 0, reducing unnecessary network calls (issue)
  • [2] use single call to load offers when resetting liabilities (issue)
  • [2] Faster network calls using fasthttp (issue)
@nikhilsaraf nikhilsaraf added the bug Something isn't working label Aug 4, 2020
@nikhilsaraf nikhilsaraf added this to the v2.0.0 milestone Aug 4, 2020
@nikhilsaraf nikhilsaraf self-assigned this Aug 4, 2020
@nikhilsaraf nikhilsaraf changed the title streamline network requests [40] streamline network requests Aug 18, 2020
@nikhilsaraf
Copy link
Contributor Author

nikhilsaraf commented Oct 25, 2020

The bot prints out the time taken by the update function for everything except the submit operation.

Benchmarks:

  • time for update() with all network requests: ~4.2s
  • time for update() with all network requests turned off: 1-2 ms 🔥

This means we can drive a lot more performance from the bot.

See uploaded pprof files for the above.
profiler_no_network.data.gz
profiler_with_network.data.gz

@nikhilsaraf nikhilsaraf changed the title [40] streamline network requests [Epic] [40] streamline network requests Oct 25, 2020
@nikhilsaraf nikhilsaraf modified the milestones: v2.0.0, v1.10.1 Oct 26, 2020
@nikhilsaraf nikhilsaraf changed the title [Epic] [40] streamline network requests [Epic] [13] streamline network requests Oct 26, 2020
@nikhilsaraf nikhilsaraf changed the title [Epic] [13] streamline network requests [Epic] [8] streamline network requests Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant