You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
The bot gives a significantly different base amount on some occasions.
Expected behavior
I think the correct behavior in this situation is for the bot to use base amounts that are close to the amount specified within a small range of error (to allow for non-exhaustive floating point representations and negligible losses due price or amount conversions)
Frequency
The frequency is: Sometimes
Possible Solution
This bug is likely caused by a recent adjustment of how amounts and prices are propagated to fix another issue. I don't recall the exact issue but it was a recent fix.
We can fix this issue by increasing the precision of inverted numbers. For example,
currently InvertNumber(8, 2) = 0.13, which is wrong.
it needs to be InvertNumber(8, 2) = 0.125.
Describe the bug
The bot gives a significantly different base amount on some occasions.
Expected behavior
I think the correct behavior in this situation is for the bot to use base amounts that are close to the amount specified within a small range of error (to allow for non-exhaustive floating point representations and negligible losses due price or amount conversions)
Frequency
The frequency is: Sometimes
Possible Solution
This bug is likely caused by a recent adjustment of how amounts and prices are propagated to fix another issue. I don't recall the exact issue but it was a recent fix.
We can fix this issue by increasing the precision of inverted numbers. For example,
currently InvertNumber(8, 2) = 0.13, which is wrong.
it needs to be InvertNumber(8, 2) = 0.125.
Your Environment
git hash: f7927c7
The text was updated successfully, but these errors were encountered: