Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Trades without results gives an error #371

Closed
nikhilsaraf opened this issue Feb 15, 2020 · 0 comments
Closed

Trades without results gives an error #371

nikhilsaraf opened this issue Feb 15, 2020 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nikhilsaraf
Copy link
Contributor

nikhilsaraf commented Feb 15, 2020

When a trade has no results, it gives an error

{
  "type": "https://stellar.org/horizon-errors/not_found",
  "title": "Resource Missing",
  "status": 404,
  "detail": "The resource at the url requested was not found.  This usually occurs for one of two reasons:  The url requested is not valid, or no data in our database could be found with the parameters provided."
}

this should be handled correctly by:

  1. checking if both assets exists
  2. if both exist then return a result indicating that there are no trades
  3. if at least one asset does not exist then it is ok to return the original error

Referenced issue in stellar/go: stellar/go#2280

@nikhilsaraf nikhilsaraf added the bug Something isn't working label Feb 15, 2020
@nikhilsaraf nikhilsaraf added this to the v1.8.1 milestone Feb 15, 2020
@nikhilsaraf nikhilsaraf self-assigned this Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant