Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Additions to the trades table in the sql database #318

Open
1 of 4 tasks
nikhilsaraf opened this issue Dec 16, 2019 · 1 comment
Open
1 of 4 tasks

Additions to the trades table in the sql database #318

nikhilsaraf opened this issue Dec 16, 2019 · 1 comment
Assignees
@nikhilsaraf
Labels
feature request New feature or request
Milestone
later

Comments

@nikhilsaraf
Copy link
Contributor

nikhilsaraf commented Dec 16, 2019 •
edited
Loading

Follow-up from #194

Later

  • maker/taker info in DB table
  • save trading account id in db table (what to save for centralized exchanges to make it account-based?)
  • decide if we need to save a two-way entry by swapping base/quote
  • save read_base_balance and read_quote_balance at the time of trades (note: this is different from the computed_base_balance since if the trade happened in a different ledger from when it was read by us we could possibly read a different balance.
@nikhilsaraf nikhilsaraf added the feature request New feature or request label Dec 16, 2019
@nikhilsaraf nikhilsaraf added this to the later milestone Dec 16, 2019
@nikhilsaraf nikhilsaraf mentioned this issue Dec 16, 2019
Closed
16 tasks
@nikhilsaraf nikhilsaraf modified the milestones: later, v1.8.0 Dec 18, 2019
@nikhilsaraf nikhilsaraf modified the milestones: v1.8.0, v1.8.1, v1.8.x Feb 10, 2020
@nikhilsaraf
Copy link
Contributor Author

account_id in trades table added here: #444

@nikhilsaraf nikhilsaraf modified the milestones: v1.8.x, later Sep 20, 2020
@nikhilsaraf nikhilsaraf self-assigned this Sep 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nikhilsaraf nikhilsaraf

Labels
feature request New feature or request
Projects
None yet
Milestone
later
Development

No branches or pull requests
1 participant
@nikhilsaraf