Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

[7] Kelp GUI: GUI should use pre-compiled CCXT binary to expand access to exchanges #310

Closed
3 tasks done
nikhilsaraf opened this issue Oct 22, 2019 · 0 comments
Closed
3 tasks done
Assignees
Labels
feature request New feature or request GUI issues related to the Kelp GUI
Milestone

Comments

@nikhilsaraf
Copy link
Contributor

nikhilsaraf commented Oct 22, 2019

Desired Behavior

I want to be able to run CCXT-rest without having to download and install it for my platform.

Impact

The desired behavior will allow me to run Kelp without the external dependency on CCXT-rest. The pre-compiled binary from Kelp should consist of everything that a user needs to run Kelp with all the features (such as CCXT).

Feature Suggestion

We can achieve the desired behavior by uploading the pre-compiled CCXT-rest binary and download it for our platform when the Kelp UI is first started.

Alternative Approaches

We can achieve the same result by bundling the CCXT-rest binary into the Kelp golang binary using the [pkg](https://github.com/zeit/pkg) tool. We can then use something like [vfsgen](github.com/shurcooL/vfsgen) or [go-bindata](https://github.com/jteeuwen/go-bindata) to bundle up the ccxt-rest binary into the golang binary. Downside of this is that we may need to write this to disk before running it as a process from the os, which is why I'm punting on this approach.

  • automate creation of pre-compiled binary for ccxt-rest
  • upload pre-compiled ccxt binaries to kelp releases
  • GUI server should download pre-compiled ccxt-binary and start process on startup only if not already started
@nikhilsaraf nikhilsaraf added feature request New feature or request GUI issues related to the Kelp GUI labels Oct 22, 2019
@nikhilsaraf nikhilsaraf added this to the v1.8.0 milestone Oct 22, 2019
@nikhilsaraf nikhilsaraf self-assigned this Oct 22, 2019
@nikhilsaraf nikhilsaraf changed the title [3] Bundle CCXT library into Kelp's golang library for the GUI [7] Bundle CCXT library into Kelp's golang library for the GUI Oct 25, 2019
@nikhilsaraf nikhilsaraf changed the title [7] Bundle CCXT library into Kelp's golang library for the GUI [7] GUI should use pre-compiled CCXT binary to expand access to exchanges Oct 25, 2019
@nikhilsaraf nikhilsaraf changed the title [7] GUI should use pre-compiled CCXT binary to expand access to exchanges [7] Kelp GUI: GUI should use pre-compiled CCXT binary to expand access to exchanges Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request New feature or request GUI issues related to the Kelp GUI
Projects
None yet
Development

No branches or pull requests

1 participant