Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

Unexpected effect from setting inflation #390

Closed
istrau2 opened this issue Sep 1, 2017 · 5 comments
Closed

Unexpected effect from setting inflation #390

istrau2 opened this issue Sep 1, 2017 · 5 comments
Assignees

Comments

@istrau2
Copy link

istrau2 commented Sep 1, 2017

It seems that setting the inflation destination on an account produces a SIGNER UPDATED effect. I found that quite unexpected (and frightening).

@vogel
Copy link

vogel commented Sep 4, 2017

Do you have ledger number and operation number for that inflation?

@vogel
Copy link

vogel commented Sep 4, 2017

Seems like horizon cannot handle inflation dest or not-changing-signers in set_options at all:

https://github.com/stellar/horizon/blob/ee87b148ed34156fedcbca52a2155019e7606689/src/github.com/stellar/horizon/ingest/session.go#L399

@jedmccaleb
Copy link
Contributor

I just wanted you to confirm it isn't a core issue

@vogel
Copy link

vogel commented Sep 6, 2017

It is not a core issue - horizon reports all not-removed signers as updated on every set_option operation. And there is no code to report changing the inflation destination.

@nullstyle
Copy link
Contributor

this is something I'll look into fixing today

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants