UnsuccessfulResponse exception is not thrown when using preventUnsuccessfulResponse method

[phuclh]

In the Spatie browsershot package, when using preventUnsuccessfulResponse method, it will throw UnsuccessfulResponse exception:

$browsershot->preventUnsuccessfulResponse($this->preventUnsuccessfulResponse);

But in this package, it throws Hammerstone\Sidecar\Exceptions\LambdaExecutionException, so it is hard to detect if a URL has HTTP error respond code like 404, 500, etc. Is it possible to throw UnsuccessfulResponse in Lambda environment?

Thank you!

[stefanzweifel]

I have to take a closer look at this.
The general problem with sidecar-browsershot seems to be, that users expect that Spatie's exceptions are thrown.

As mentioned in #19, maybe you can manually inspect the LambdaExectionException and in your app and act accordingly?

[phuclh]

@stefanzweifel Yeah, that is what I am using now. I just took a quick look. Seems in the BrowsershotLambda, you threw all exception with this method:

While in the Spatie package, it checks by the exit code:

[stefanzweifel]

This seems to be more complicated than I thought.

Ideally, we could reuse the exit codes from Spatie's browser.js-code and do the same $exitCode check in BrowsershotLambda@callBrowser as Spatie does.

Right now, we do not differentiate between errors and body HTML here.
(Maybe I'm wrong and Sidecar already catches possible JavaScript/Node errors thrown in execSync. Then, result.toString() would always be the body HTML of a page. @aarondfrancis Do you have any insights about this?)

@phuclh You mention that you manually inspect the LambdaExecutionException. What exactly are you doing there right now? Do you re-throw the Spatie Exceptions? Are you able to share some code?