Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not wrap vendor in eval when wrapInEval is set. #983

Merged
merged 1 commit into from
Jun 11, 2014

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jun 11, 2014

  • Ensure that using wrapInEval still creates a functional application.
  • Enable wrapInEval for app/ (aka not vendor) files while in development.

Fix #980.

@jgwhite jgwhite mentioned this pull request Jun 11, 2014
6 tasks
rwjblue added a commit that referenced this pull request Jun 11, 2014
Do not wrap vendor in eval when `wrapInEval` is set.
@rwjblue rwjblue merged commit 675d247 into ember-cli:master Jun 11, 2014
@rwjblue rwjblue deleted the do-not-wrap-vendor-in-eval branch June 11, 2014 11:38
@simonexmachina
Copy link
Contributor

@rjackson you are a saint!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting wrapInEval: true causes loader.js to fail
2 participants