Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up blueprint.js #537

Merged
merged 1 commit into from
Apr 30, 2014
Merged

Conversation

crismali
Copy link
Contributor

  • removed unnecessary assignment
  • removed unnecessary writefile function that just swapped arguments
  • made double iteration in processFiles method a simple reduce

@twokul
Copy link
Contributor

twokul commented Apr 30, 2014

doesn't merge cleanly, mind rebasing?

@@ -114,6 +109,13 @@ function markIdenticalToBeSkipped(info) {
}
}

function isNeedingConfirmation(collection, info) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needsConfirmation maybe?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the naming is strange, as the function also has side effects.
I think @twokul's suggestion might make more sense.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Actually the old .filter() -> .map() way wasn't that bad.

@rwjblue
Copy link
Member

rwjblue commented Apr 30, 2014

@crismali - Can you squash the commits?

@crismali
Copy link
Contributor Author

@rjackson sure thing

* removed unnecessary assignment
* removed unnecessary writefile function that just swapped arguments
* made double iteration in processFiles method a simple reduce
* update changelog to reflect changes
rwjblue added a commit that referenced this pull request Apr 30, 2014
@rwjblue rwjblue merged commit f5cd8df into ember-cli:master Apr 30, 2014
@@ -114,6 +108,13 @@ function markIdenticalToBeSkipped(info) {
}
}

function gatherConfirmationMessages(collection, info) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MajorBreakfast
Copy link
Contributor

@crismali 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants