refactored the test loader to iterate once and be a bit more readable #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crismali could you please update the Changelog? |
|
Sorry about that, I'll remember to update it next time :) |
twokul
added a commit
that referenced
this pull request
Apr 30, 2014
refactored the test loader to iterate once and be a bit more readable
|
@crismali thanks! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevented the test loader from iterating twice (not really a performance win, but still unnecessary work) and made things a bit more readable.
requirejs.entriesandentryare easier to understand thanrequirejs._eak_seenandkey(to me at least).