Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ic-ajax to ignored modules #378

Merged
merged 1 commit into from
Apr 16, 2014
Merged

Adds ic-ajax to ignored modules #378

merged 1 commit into from
Apr 16, 2014

Conversation

twokul
Copy link
Contributor

@twokul twokul commented Apr 16, 2014

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Apr 16, 2014

CHANGELOG.md update?

@rwjblue
Copy link
Member

rwjblue commented Apr 16, 2014

Background for others, this allows you to import ic-ajax in your tests. Otherwise the module validation would fail (even though it was previously included in the app tree).

rwjblue
rwjblue reviewed Apr 16, 2014
View reviewed changes
CHANGELOG.md
@@ -12,6 +12,7 @@
* locks it to version `0.2.0`
* Fix issue where app.js files are appended to tests.js ([#347](https://github.com/stefanpenner/ember-cli/pull/347))
* upgrade broccoli to `0.9.0` [v0.9.0 brocfile changes](https://gist.github.com/joliss/15630762fa0f43976418)
* Adds `ic-ajax` to the list of ignored modules for tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link the PR also?

@MajorBreakfast
Copy link
Contributor

I think it would be more sensible to:

  • have one tree that contains app and tests for development builds
  • exclude the tests in production builds

Better than playing Whac-A-Mole :)

@rwjblue
Copy link
Member

rwjblue commented Apr 16, 2014

@MajorBreakfast - In general I agree, but in the meantime whack-a-mole has relatively low cost and the benefit of helping new-comers until we can figure out the best way forward.

I think the better solution would be to modify broccoli-es6-concatenator to make the actual "found modules" listing available. This would allow us to fix #334 as well.

@stefanpenner
Copy link
Contributor

merging for now, with near future plans to follow what señor @MajorBreakfast outlined.

stefanpenner added a commit that referenced this pull request Apr 16, 2014
@stefanpenner
Merge pull request #378 from twokul/ic-ajax
a703266 
Adds ic-ajax to ignored modules
@stefanpenner stefanpenner merged commit a703266 into ember-cli:master Apr 16, 2014
@twokul twokul deleted the ic-ajax branch April 16, 2014 19:45
homu added a commit that referenced this pull request Mar 16, 2017
@homu
Auto merge of #6859 - ember-cli:greenkeeper/fs-extra-2.1.0, r=Turbo87
d0c1aaa 
Update fs-extra to the latest version 🚀

## Version **2.1.0** of [fs-extra](https://github.com/jprichardson/node-fs-extra) just got published.

<table>
  <tr>
    <th align=left>
      Dependency
    </td>
    <td>
      fs-extra
    </td>
  </tr>
  <tr>
    <th align=left>
      Current Version
    </td>
    <td>
      2.0.0
    </td>
  </tr>
  <tr>
    <th align=left>
      Type
    </td>
    <td>
      dependency
    </td>
  </tr>
</table>

The version **2.1.0** is **not covered** by your **current version range**.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of fs-extra.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

---

<details>
<summary>Commits</summary>
<p>The new version differs by 87 commits .</p>
<ul>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/90b3609b894b27ff9ccd1f820c9a2eb44314f809"><code>90b3609</code></a> <code>2.1.0</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/6ebcb9cc287997c7390482a657d230c47a1e5743"><code>6ebcb9c</code></a> <code>Update CHANGELOG</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/efe0d80be465a6f5cbbbe41e95c091dad90c4ab0"><code>efe0d80</code></a> <code>Merge pull request #378 from jdalton/move-check</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/8d978db84dd7e236f6d34b740cb641d823480be5"><code>8d978db</code></a> <code>Don't move when source and dest paths are the same.</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/cf2c50d1f31ecfa0e07ead42bb60f05c5bdeadf9"><code>cf2c50d</code></a> <code>Merge pull request #386 from jprichardson/changelog</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/4db96c553cff3a35881eb13b09a0b4b54c2e3ac4"><code>4db96c5</code></a> <code>Update CHANGELOG</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/1f301611d1ce148210489aa715c1e05605d62956"><code>1f30161</code></a> <code>Merge pull request #384 from jprichardson/docs-cleanup-async-methods</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/83a61908906d018830def2b2c408471ec746f809"><code>83a6190</code></a> <code>docs: Refactor remove exmaple to use remove instead of removeSync</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/936011e253a0c8605f1a4a858e170226d6f46b80"><code>936011e</code></a> <code>docs: Refactor remove and removeSync parameter name</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/fc5fca9be1fdcc0ab6d69d5aa50dd0118f950ecc"><code>fc5fca9</code></a> <code>docs: Refactor docs to include parameters type</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/e46b820dc5da6418afe184ed2c1b756ab09946f7"><code>e46b820</code></a> <code>Merge pull request #383 from jprichardson/docs-refactor-readJson-example</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/a4f6481ebf67a6327f381426a26b3b27677e0589"><code>a4f6481</code></a> <code>docs/readJson.md: Refactor example for readJson method, refactor move and moveSync tests descriptions</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/b5c72dcf7bbad3dd4ef3b1268721de0fd3ec9575"><code>b5c72dc</code></a> <code>Merge pull request #382 from jprichardson/docs-split-out-sync-methods</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/10756de4df113704d921789a64a72aed06998272"><code>10756de</code></a> <code>docs: Refactor readJsonSync example</code></li>
<li><a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/commit/02c2a629b8dee9e11cb6ce8e5b18f1f8ff4742e4"><code>02c2a62</code></a> <code>Docs: Split out sync methods</code></li>
</ul>
<p>There are 87 commits in total. See the <a href="https://urls.greenkeeper.io/jprichardson/node-fs-extra/compare/fcfa595ca022011ce0f61d337598a4573fe8eb3c...90b3609b894b27ff9ccd1f820c9a2eb44314f809">full diff</a>.</p>
</details>

<details>
<summary>Not sure how things should work exactly?</summary>

There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---

Your [Greenkeeper](https://greenkeeper.io) Bot 🌴
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@twokul @rwjblue @MajorBreakfast @stefanpenner