fail better with watchman #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@calvinmetcalf awesome, i was going to do this later today, but I appreciate the fix. |
| try { | ||
| version = JSON.parse(output).version; | ||
| } catch(e) { | ||
| version = '0.0.0'; |
There was a problem hiding this comment.
should we maybe instead log a useful error and fall back to options.watcher = 'node' ?
There was a problem hiding this comment.
ideally something short but actionable
| version = JSON.parse(output).version; | ||
| } catch(e) { | ||
| options.watcher = 'node'; | ||
| debug('looks like you have a different program called watchman, falling back to NodeWatcher'); |
There was a problem hiding this comment.
sorry misleading.
debug is actually just our internal debug logging, via https://github.com/visionmedia/debug
ui.writeLine is for humanized default output
|
I suspect this also fixes: #2599 |
|
LGTM, will merge when green thanks! |
|
thank you sir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #2644