Refactor: Add Multiple bower packages in one statement #2222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterchoo i like!, Can you add tests? |
|
Tests have been added, let me know if you want any changes to them, they are essentially a copy of the single package tests. I intend to extend this to affect the |
|
Actually, hold fire on merging this in yet, I am going to re-write the |
Remove unnecessary semicolon Add tests for addBowerPackagesToProject Properly test addBowerPackageToProject
peterchoo
force-pushed
the
addBowerPackages
branch
from
dbdf09a
to
679225d
Compare
|
👍 |
|
Squished, ready for review :) |
|
Also, for reference, definitely separate PR's for different things. I'd much prefer to keep PR's relatively atomic (it makes my life easier when doing the changelog entries). |
|
👍 |
stefanpenner
added a commit
that referenced
this pull request
Oct 7, 2014
Refactor: Add Multiple bower packages in one statement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes adding multiple bower packages easier.